This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Closed
Conversation
coderobe
added
A0-please_review
14 tasks
chevdor
reviewed
Sep 30, 2022
Comment on lines
+51
to
+53
| Weight::from_ref_time(5_488_493_000 as u64) | ||
| // Standard Error: 136_134 | ||
| .saturating_add(Weight::from_ref_time(5_576_665 as u64).saturating_mul(v as u64)) |
chevdor
suggested changes
Sep 30, 2022
Contributor
chevdor
left a comment
chevdor
left a comment
There was a problem hiding this comment.
Reviewing the values, this run seems rather odd compared to the several previous releases we had.
The weights in some pallets look great (= very steady as we are used to). For others however, we can see huge bumps and quite some from 0 to several billions.
@coderobe we should start a new benchmark run. We can decide later to use the results or not.
I also would like to gather @kianenigma & @ggwpez's opinions on the big changes I spotted. There are more bing changes than whan I reported.
Comment on lines
+61
to
+63
| Weight::from_ref_time(4_332_183_000 as u64) | ||
| // Standard Error: 146_563 | ||
| .saturating_add(Weight::from_ref_time(5_508_430 as u64).saturating_mul(v as u64)) |
Comment on lines
+49
to
+51
| Weight::from_ref_time(3_031_000 as u64) | ||
| // Standard Error: 0 | ||
| .saturating_add(Weight::from_ref_time(1_000 as u64).saturating_mul(b as u64)) | ||
| .saturating_add(Weight::from_ref_time(512 as u64).saturating_mul(b as u64)) |
Comment on lines
54
to
+57
| fn remark_with_event(b: u32, ) -> Weight { | ||
| Weight::from_ref_time(0 as u64) | ||
| Weight::from_ref_time(11_653_000 as u64) | ||
| // Standard Error: 0 | ||
| .saturating_add(Weight::from_ref_time(2_000 as u64).saturating_mul(b as u64)) | ||
| .saturating_add(Weight::from_ref_time(1_829 as u64).saturating_mul(b as u64)) |
Comment on lines
68
to
+71
| fn set_storage(i: u32, ) -> Weight { | ||
| Weight::from_ref_time(0 as u64) | ||
| // Standard Error: 2_000 | ||
| .saturating_add(Weight::from_ref_time(610_000 as u64).saturating_mul(i as u64)) | ||
| Weight::from_ref_time(3_843_000 as u64) | ||
| // Standard Error: 1_590 | ||
| .saturating_add(Weight::from_ref_time(578_944 as u64).saturating_mul(i as u64)) |
Comment on lines
+78
to
+81
| Weight::from_ref_time(3_896_000 as u64) | ||
| // Standard Error: 955 | ||
| .saturating_add(Weight::from_ref_time(434_545 as u64).saturating_mul(i as u64)) | ||
| .saturating_add(T::DbWeight::get().writes(1 as u64)) |
Comment on lines
+152
to
+159
| fn clean_defunct_voters(v: u32, _d: u32, ) -> Weight { | ||
| Weight::from_ref_time(282_352_767_000 as u64) | ||
| // Standard Error: 243_946 | ||
| .saturating_add(Weight::from_ref_time(35_271_908 as u64).saturating_mul(v as u64)) | ||
| .saturating_add(T::DbWeight::get().reads(15004 as u64)) | ||
| .saturating_add(T::DbWeight::get().reads((2 as u64).saturating_mul(v as u64))) | ||
| .saturating_add(T::DbWeight::get().writes(15000 as u64)) | ||
| .saturating_add(T::DbWeight::get().writes((2 as u64).saturating_mul(v as u64))) |
Comment on lines
+174
to
+179
| Weight::from_ref_time(29_157_699_000 as u64) | ||
| // Standard Error: 525_734 | ||
| .saturating_add(Weight::from_ref_time(43_642_232 as u64).saturating_mul(v as u64)) | ||
| // Standard Error: 33_738 | ||
| .saturating_add(Weight::from_ref_time(2_196_265 as u64).saturating_mul(e as u64)) | ||
| .saturating_add(T::DbWeight::get().reads(1968 as u64)) |
Comment on lines
+51
to
+53
| Weight::from_ref_time(30_131_000 as u64) | ||
| // Standard Error: 1 | ||
| .saturating_add(Weight::from_ref_time(2_441 as u64).saturating_mul(s as u64)) |
Comment on lines
+366
to
+374
| fn get_npos_voters(v: u32, n: u32, _s: u32, ) -> Weight { | ||
| Weight::from_ref_time(25_645_050_000 as u64) | ||
| // Standard Error: 467_573 | ||
| .saturating_add(Weight::from_ref_time(10_912_850 as u64).saturating_mul(v as u64)) | ||
| // Standard Error: 467_573 | ||
| .saturating_add(Weight::from_ref_time(10_774_564 as u64).saturating_mul(n as u64)) | ||
| .saturating_add(T::DbWeight::get().reads(6706 as u64)) | ||
| .saturating_add(T::DbWeight::get().reads((2 as u64).saturating_mul(v as u64))) | ||
| .saturating_add(T::DbWeight::get().reads((1 as u64).saturating_mul(n as u64))) |
Comment on lines
+154
to
+157
| Weight::from_ref_time(5_768_526_000 as u64) | ||
| // Standard Error: 268_593 | ||
| .saturating_add(Weight::from_ref_time(17_016_045 as u64).saturating_mul(v as u64)) | ||
| .saturating_add(T::DbWeight::get().reads(29 as u64)) |
Member
|
A lot of the changes are probably due to paritytech/substrate#11806 |
Contributor
Author
|
not merging this round |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏋️♀️ related #6025